Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change : consider Operational dispatch class #952

Open
enthusiastmartin opened this issue Nov 20, 2024 · 1 comment
Open

Change : consider Operational dispatch class #952

enthusiastmartin opened this issue Nov 20, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@enthusiastmartin
Copy link
Contributor

It would be good to change normal dispatch class for some important calls:

  • pallet_transaction_pause::pause_transaction
  • pallet_omnipool::set_asset_tradable_state
  • pallet_stableswap::set_asset_tradable_state

it should help when we need to pause transaction, as operational class has the highest priority and ignores block weight limits.

To research: verify that operational class does not have any "side effects".
@enthusiastmartin enthusiastmartin added the good first issue Good for newcomers label Nov 20, 2024
@sylvaincormier
Copy link

Hi everyone! I'd like to signal that I will start working on this issue as part of the Kudos Carnival. ty

@sylvaincormier sylvaincormier mentioned this issue Dec 8, 2024
Closed
sylvaincormier added a commit to sylvaincormier/hydration-node that referenced this issue Dec 10, 2024
@sylvaincormier
feat: introduce operational dispatch class for specific calls (galact…
d2a6815 
…iccouncil#952)
@sylvaincormier sylvaincormier mentioned this issue Dec 10, 2024
Open
sylvaincormier added a commit to sylvaincormier/hydration-node that referenced this issue Dec 10, 2024
@sylvaincormier
feat: introduce operational dispatch class for specified critical cal…
65b6d48 
…ls (galacticcouncil#952)

This commit changes the dispatch class to operational for critical transactions across:
- `pallet_transaction_pause::pause_transaction`
- `pallet_omnipool::set_asset_tradable_state`
- `pallet_stableswap::set_asset_tradable_state`

This ensures these important extrinsics can bypass block weight limits and be executed promptly.

Additionally, operational-class tests have been introduced to verify behavior both under normal and operational conditions. The new integration tests cover scenarios to ensure that these calls function as intended, providing better resiliency and control over the execution of critical operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvaincormier @enthusiastmartin