-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
area/authAuthentication and authorizationAuthentication and authorizationarea/databaseGalaxy's database or data access layerGalaxy's database or data access layerarea/testingkind/enhancementkind/refactoringcleanup or refactoring of existing code, no functional changescleanup or refactoring of existing code, no functional changes
Description
The custos authnz unit tests use mocked representations of SQLAlchemy objects to test the galaxy.authnz.custos_authnz
module. In doing so, they break the code base when the module under test refernces (directly or indirectly) a SQLAlchemy object that used in a way that is not mocked out in this test module.
The test module needs a complete rewrite. SQLAlchemy objects should not be mocked.
For context, see #20893
Metadata
Metadata
Assignees
Labels
area/authAuthentication and authorizationAuthentication and authorizationarea/databaseGalaxy's database or data access layerGalaxy's database or data access layerarea/testingkind/enhancementkind/refactoringcleanup or refactoring of existing code, no functional changescleanup or refactoring of existing code, no functional changes