-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated typescript types for v5 release #502
Comments
Hey, thanks bunch for this. |
Noted. @CosminPerRam noticed an irregular/undocumented prop: games[].options.query_port https://github.com/gamedig/node-gamedig/blob/master/lib/games.js#L1828 |
It has been mentioned some time ago that |
I'm not sure if this is fixed and can be closed, or if we should do something else here? |
DT merged/released it so i guess so. Other changes can go to DT directly. On a different note: for beta releases in the npmjs registry it would be better to use the |
I created a PR draft at DefinitelyTyped for the current #master branch (future v5): DefinitelyTyped/DefinitelyTyped#68279
Any suggestion/contribution is welcome, i only submitted this issue to create awareness that this exists. (I hope thats ok.)
Once v5.x.x is released on npmjs the eslint rule:
"@definitelytyped/npm-naming": "off"
can be removed and the PR merged if no new feature or change is added to gamedig.The text was updated successfully, but these errors were encountered: