Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form is not working #29

Open
kitarp29 opened this issue Dec 6, 2020 · 10 comments
Open

Form is not working #29

kitarp29 opened this issue Dec 6, 2020 · 10 comments
Assignees
Labels
Beginner enhancement New feature or request good first issue Good for newcomers NWoC 2020

Comments

@kitarp29
Copy link

kitarp29 commented Dec 6, 2020

On the create ToDo Log page the form that takes s username is not working.
I can work on this issue if you assign it to me

@kitarp29
Copy link
Author

kitarp29 commented Dec 6, 2020

@garimasingh128

@MuhammadTanveer94
Copy link

@garimasingh128 i want to do this if u assigned me?

@Nishant2907
Copy link

Hi @garimasingh128 kindly assign me this issue :)

@kitarp29
Copy link
Author

Hi @garimasingh128
I cloned and went through the project.
First of all KUDOS on writing such nice and well-formatted code.
Coming to the topic at hand,
On this page, the React component for Username is using a <select> tag that renders and displays data fetched from the DB.
This will work when it fetches data from the DB and display the usernames to get selected.

I can either change this to an <input> tag and make the options function obsolete.

Or work on the DB side to make sure the data is fetched and rendered here.

Which one should I do???

In the case of Description:, it uses an <input> so can be used right now.
image

@garimasingh128
Copy link
Owner

The username basically will show up a drop down menu with all the registered users. You don't have to input them explicitly, like we do in description so I think the second option will be better.

@yashgautam9274
Copy link

I want to work on this issue

@tirlochanarora16
Copy link

tirlochanarora16 commented Dec 25, 2020

Has someone started to work on this or can I start?

@kitarp29
Copy link
Author

I will not be working on this issue @garimasingh128.
So If you want then reassign it some one

@tirlochanarora16
Copy link

How to set up the local environment for testing the changes?

@skanda1395
Copy link

skanda1395 commented Dec 22, 2021

If the server is running, the user list is fetched and displayed properly. I think that was the intent of the author, so form will work in that case. If there are no users, then they should be redirected to create user page with alert saying "Please create user to create a log" or something like that.

I've got a PR related to this. @garimasingh128
Do check and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner enhancement New feature or request good first issue Good for newcomers NWoC 2020
Projects
None yet
Development

No branches or pull requests

7 participants