Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check proper creation of EmbeddedSdf.cc #1536

Open
wants to merge 1 commit into
base: sdf15
Choose a base branch
from
Open

check proper creation of EmbeddedSdf.cc #1536

wants to merge 1 commit into from

Conversation

efferre79
Copy link

@efferre79 efferre79 commented Feb 4, 2025 •
edited by azeey
Loading

Closes: #1535

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Feb 4, 2025
azeey
azeey approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

Note that file(SIZE was added in 3.14 but the minimum CMake version in the sdf14 branch is 3.12, so we should not backport this PR. @efferre79 let me know if you want to work on a different approach. Otherwise, we'll merge this as is, but not backport to older versions.

@scpeters
Copy link
Member

scpeters commented Feb 4, 2025

is there an easy way to reproduce this bug? I'd like to see what console output it gives

@azeey
Copy link
Collaborator

azeey commented Feb 4, 2025

is there an easy way to reproduce this bug? I'd like to see what console output it gives

I just added an intentional error in embedSdf.py

-- Install prefix: /home/addisuzt/ws/ionic/install
Traceback (most recent call last):
  File "/home/addisuzt/ws/ionic/src/sdformat/sdf/embedSdf.py", line 13, in <module>
    intentional_error
NameError: name 'intentional_error' is not defined
CMake Error at sdf/CMakeLists.txt:28 (file):
  file SIZE requested of path that is not readable:

    /home/addisuzt/ws/ionic/build/sdformat15/src/EmbeddedSdf.cc


CMake Error at sdf/CMakeLists.txt:29 (if):
  if given arguments:

    "EQUAL" "0"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

@efferre79
Copy link
Author

LGTM! Thanks for the contribution!

Note that file(SIZE was added in 3.14 but the minimum CMake version in the sdf14 branch is 3.12, so we should not backport this PR. @efferre79 let me know if you want to work on a different approach. Otherwise, we'll merge this as is, but not backport to older versions.

on my system cmake is 3.30.6 so I am not interested in finding a different approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v9 build failure ‘conversionMap’ was not declared in this scope
3 participants
@efferre79 @scpeters @azeey