-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split providers from this package #60
Comments
I think it makes sense to split it off (we've talked about it in the past), but I'm not sure I understand what you are suggesting. I feel like there are three components:
There are also utilities which are only used in the providers. So I think what you are suggesting (and what makes a lot of sense) is this:
Is my understanding correct? I feel like we need a new major release anyway for certain things related to JSKOS API 2.0, so we can also add a breaking change to the error classes. If tree-shaking can be used with |
Yes. cocoda-sdk should be usable as before.
I'm not sure which to go:
Although tree-shaking is possible, I'd prefer packages with less dependencies (but maybe we don't need that many additional dependencies anyway). Variant 3 seems best in theory but requires additional setup complexity. |
I agree that variant 3 seems like the best. In this case, a monorepo pushlished as multiple separate packages makes a lot of sense to me. |
The sdk is also used independently from Cocoda so another name may be a better fit. Renaming is a breaking change and parts of this module may still have focus on Cocoda, so how about:
jskos-providers
with providers (that's the main part of this package)lib/CocodaSDK.js
in this packageOnly breaking change may be renaming
CDKError
toJSKOSProviderError
but adding the latter as subclass of the former and superclass of specific error classes may also work.The text was updated successfully, but these errors were encountered: