Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how analyses of long notations are displayed on small devices #67

Open
4 tasks
stefandesu opened this issue Jan 28, 2022 · 1 comment
Open
4 tasks
Labels
low priority maybe later

Comments

@stefandesu
Copy link
Member

Here's how it looks on my phone:
IMG_4E086624352E-1

As you can see, the layout breaks as soon as a caption includes a longer word (because there's not enough horizontal space). I don't think it's possible to fix this for all numbers, but there are some small improvements we could make:

  • Reduce left/right margins
  • If there's not enough space, only show the ellipsis and hide all other icons in there
  • Check if CSS can be adjusted so words break in the middle of the word
  • For very long notations, we could also move the caption into the popover and only show the notation part and the ellipsis

This obviously has a very low priority, but it can't hurt to have it as an issue.

@stefandesu stefandesu added the low priority maybe later label Jan 28, 2022
@nichtich
Copy link
Member

nichtich commented Feb 1, 2022

On very narrow devices the label should better be hidden or abbreviated. The notation after the label should still be shown, maybe after a colon instead of paranthesis ("Künste: 700", "Museen...: T1--0901-T1--0905:074"...). For large numbers the device must be switched to landscape orientation anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority maybe later
Projects
None yet
Development

No branches or pull requests

2 participants