Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Pica3 representation of table numbers #79

Open
stefandesu opened this issue Jan 25, 2024 · 2 comments
Open

Check Pica3 representation of table numbers #79

stefandesu opened this issue Jan 25, 2024 · 2 comments
Labels
bug Something is broken

Comments

@stefandesu
Copy link
Member

Fixing the DDC notation pattern caused the Pica3 representation to change. For our monitoring example, it changed from

5420 [23]700.90440747471-G--7-T1--09044-T1--074-T2--7471$Acoli-ana

to

5420 [23]700.90440747471-G--7-T1--09044-T1--0901-0905%3A074-T2--7471$Acoli-ana

The included numbers changed slightly (even though the actual result on the web UI did not change), and it now includes a table number with : which is encoded here as %3A.

Note that I will change the monitoring for now so that it won't bug us about this. I might change it back as soon as this is fixed.

@stefandesu stefandesu added the bug Something is broken label Jan 25, 2024
@stefandesu
Copy link
Member Author

I think it's an encoding issue with the : in the notation. When comparing the JSON:

❯ diff 0.4.1.json 0.5.1.json                                         
183c183                                                              
<         "uri": "http://dewey.info/class/1--0901-0905:07/e23/",     
---                                                                  
>         "uri": "http://dewey.info/class/1--0901-0905%3A07/e23/",   
185c185                                                              
<           "T1--0901-0905:07",                                      
---                                                                  
>           "T1--0901-0905%3A07",                                    
193c193                                                              
<         "uri": "http://dewey.info/class/1--0901-0905:074/e23/",    
---                                                                  
>         "uri": "http://dewey.info/class/1--0901-0905%3A074/e23/",  
195c195                                                              
<           "T1--0901-0905:074",                                     
---                                                                  
>           "T1--0901-0905%3A074",                                   
204c204                                                              
<             "uri": "http://dewey.info/class/1--0901-0905:07/e23/"  
---                                                                  
>             "uri": "http://dewey.info/class/1--0901-0905%3A07/e23/"

I will look into it.

@stefandesu
Copy link
Member Author

This is a bug in jskos-tools: gbv/jskos-tools#41

However, it opened up discussion on how to handle these kinds of table range notations in general: gbv/jskos-data#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant