Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify at login that a new account will be created #48

Closed
stefandesu opened this issue Mar 31, 2020 · 4 comments
Closed

Clarify at login that a new account will be created #48

stefandesu opened this issue Mar 31, 2020 · 4 comments
Labels
Milestone

Comments

@stefandesu
Copy link
Member

Specifically mention that the user first has to log into the existing account before connecting an additional identity. The purpose is to prevent users from accidentally creating two separate accounts instead of one account with two identities.

@stefandesu stefandesu added the user experience undefined label Mar 31, 2020
@stefandesu
Copy link
Member Author

If a user logs into an account which is not yet connected to an existing user account (i.e. a new account would be created), we could add an additional page that does something like the following:

  • Login via {Provider X} was successful; no active user account was found. Button: Create Account
  • Alternatively, log into other provider and connect the account for {Provider X} with an existing user account.

The second part might not be easy to implement because we will have to temporarily save the data from {Provider X} somewhere, but it should be possible with the session.

@stefandesu stefandesu added this to the 1.0.0 milestone Jul 2, 2020
stefandesu added a commit that referenced this issue Sep 23, 2020
@nichtich nichtich mentioned this issue Jan 12, 2021
5 tasks
@nichtich nichtich modified the milestones: 1.0.0, 0.4.0 Jan 13, 2021
@stefandesu stefandesu modified the milestones: 0.4.0, 0.5.0 Jan 15, 2021
@stefandesu
Copy link
Member Author

Since this issue requires some changes in application flow (as mentioned in my previous comment), I would suggest moving it to 0.5.0 (or maybe to a 0.4.1).

@stefandesu
Copy link
Member Author

I wonder if this is really necessary. It already says on the login page:

If necessary, a new user account will be created on first login.

The only use case I can think of is when a user logs in with a different provider than previously and now has two accounts. However, how often does that happen, and is it really such a big problem?

I would vote for not changing this. Maybe we can simply add another sentence like "To connect an additional provider to your existing account, please log into that existing account first."

@nichtich ?

@nichtich
Copy link
Member

Not required as accounts get merged if used with same identity.

@nichtich nichtich closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants