Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused fields in REST SystemProperty.java #3208

Open
GCHQDeveloper314 opened this issue May 7, 2024 · 1 comment
Open

Unused fields in REST SystemProperty.java #3208

GCHQDeveloper314 opened this issue May 7, 2024 · 1 comment
Assignees
@rohit-satya
Labels
good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge tech-debt Relates to Technical Debt
Milestone
Backlog

Comments

@GCHQDeveloper314
Copy link
Member

Describe the issue
In SystemProperty.java the fields SERVICES_PACKAGE_PREFIX and SERVICES_PACKAGE_PREFIX_DEFAULT are declared but are not used anywhere in the Gaffer codebase.

It's possible they were used at the time they were added and have since become redundant. The history behind them should be investigated and if not required these fields should be removed.

Expected situation
The codebase shouldn't contain unused code, unless there's a good reason for it.
@GCHQDeveloper314 GCHQDeveloper314 added tech-debt Relates to Technical Debt good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge labels May 7, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone May 7, 2024
@rohit-satya
Copy link

@GCHQDeveloper314 Please assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohit-satya rohit-satya

Labels
good first issue Small, lower complexity and doesn't require pre-existing Gaffer knowledge tech-debt Relates to Technical Debt
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@GCHQDeveloper314 @rohit-satya