Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainedIterator doesn't have a varargs constructor #321

Open
GCHQDeveloper314 opened this issue Apr 18, 2024 · 0 comments · May be fixed by #328
Open

ChainedIterator doesn't have a varargs constructor #321

GCHQDeveloper314 opened this issue Apr 18, 2024 · 0 comments · May be fixed by #328
Labels
enhancement Improvement to existing functionality/feature good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge
Milestone
v2.6.0

Comments

@GCHQDeveloper314
Copy link
Member

In ChainedIterable.java there's a varargs constructor to take any number of Iterables to create a single Iterable:

koryphe/core/src/main/java/uk/gov/gchq/koryphe/iterable/ChainedIterable.java

Line 39 in 36c63c3

public ChainedIterable(final Iterable<? extends T>... iterables) {

The ChainedIterator.java class is very similar but is missing this kind of constructor.
@GCHQDeveloper314 GCHQDeveloper314 added the enhancement Improvement to existing functionality/feature label Apr 18, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.6.0 milestone Apr 18, 2024
@GCHQDeveloper314 GCHQDeveloper314 added the good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge label Dec 31, 2024
@github-actions github-actions bot linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Gh-321: Add ChainedIterator varargs constructor and IterableMerge binary operator gchq/koryphe
1 participant
@GCHQDeveloper314