Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability of dependency "golang.org/x/net" #157

Open
Silence-worker-02 opened this issue Jul 13, 2023 · 2 comments
Open

Vulnerability of dependency "golang.org/x/net" #157

Silence-worker-02 opened this issue Jul 13, 2023 · 2 comments

Comments

@Silence-worker-02
Copy link

Hello, we are a team researching the dependency management mechanism of Golang. During our analysis, we came across your project and noticed that it contains a vulnerability (CVE-2022-41723). In your project, the golang.org/x/net package is being used at version golang.org/x/net v0.0.0-20220520000938-2e3eb7b945c2, but the patched version is v0.7.0. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v0.7.0. Thank you for your attention to this matter.

@Silence-worker-02
Copy link
Author

We also came across your project and noticed that it contains a vulnerability (CVE-2022-32149). In your project, the golang.org/x/text package is being used at version golang.org/x/text v0.3.7, but the patched version is v0.3.8. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v0.3.8 or higher. Thank you for your attention to this matter.

@bucketcat
Copy link

bucketcat commented Dec 5, 2023

Any reason why Dependabot (properly configured for Go) isn't picking up on this?

Edit: Because x/Net is being inherited through the x wildcard. Adding x/Net to go.mod caused it to instantly pick up on it.

This is maybe an issue with Dependabot not going through all sub packages and lazy developers importing entire packages rather than being narrow.

bucketcat added a commit to bucketcat/termshark that referenced this issue Dec 5, 2023
gcla/termshark#157

Make sure to run 'go mod tidy' as this was an in-situ edit of go.mod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants