Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversion from Array to String #57

Open
ghost opened this issue Oct 13, 2018 · 3 comments
Open

Implicit conversion from Array to String #57

ghost opened this issue Oct 13, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2018

There is a implicit conversion from array to a string in https://github.com/ge0rg/MemorizingTrustManager/blob/master/src/de/duenndns/ssl/MemorizingTrustManager.java#L413, which causes the hashCode to be printed and I'm not sure if that information is useful.

@ge0rg
Copy link
Owner

ge0rg commented Oct 21, 2018

Good catch. It's not useful, but I'm not sure what would be, without significant effort. The length of the array maybe?

@mueller-ma
Copy link

I don't have an idea either. Printing the whole chain exceeds the string size for a log message. Maybe just remove it from the log message or write a function that extracts the CN from the certs in the chain.

@mueller-ma
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants