Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ep_tables plugin breaks the pad timeslider #10

Open
Wikinaut opened this issue Nov 25, 2012 · 6 comments
Open

ep_tables plugin breaks the pad timeslider #10

Wikinaut opened this issue Nov 25, 2012 · 6 comments
Assignees

Comments

@Wikinaut
Copy link

The ep_tables plugin breaks timeslider immediately.

This has to do with an ep_tables related anonymous function which is incorrectly loaded, I saw this in the Firebug console.

I am currently trying to find the timeslider bug and came accross this problem.

@disy-mk
Copy link

disy-mk commented Dec 11, 2012

bump

This is a severe issue, but I have not any clue where to start looking, although the dev-tools console of google chrome seems to give a bit more information. This is what I am able to contribute:

Uncaught TypeError: Cannot read property 'length' of undefined
exports.acePostWriteDomLineHTML
normalizedhook ace2_common.js:11739
hookCallWrapper ace2_common.js:11745
(anonymous function) ace2_common.js:11799
.map..collect ace2_common.js:10183
exports.callAll ace2_common.js:11798
writeHTML timeslider.js:4979
padContents.lineToElement timeslider.js:5632
(anonymous function) timeslider.js:6061
handleClientVars timeslider.js:161
(anonymous function) timeslider.js:87
EventEmitter.emit socket.io.js:633
SocketNamespace.onPacket socket.io.js:2239
Socket.onPacket socket.io.js:1930
Transport.onPacket socket.io.js:1332
Transport.onData socket.io.js:1303
JSONPPolling._ socket.io.js:2900
(anonymous function) socket.io.js:2747
(anonymous function) Gn4hcsMSqO9U56uQ53HW:1

@ghost ghost assigned gedion Jan 23, 2013
@Exceltoi
Copy link

Thanks for ep-tables, it's a very good plugin.

But this problem with timeslider is very unpleasant because it isn't easy to find why timeslider didn't work.

May be it's usefull if you put an information on the page https://npmjs.org/package/ep_tables to inform user that if he wants to use timeslider it's better for him to not install ep_tables.

I don't know Js programmation but perhaps it's possible to add an option on the Pad Settings for disable ep_tables before to use timeslider. Does he exist a way to desactivate a plugin without uninstall it ?

@mangelajo
Copy link

It breaks my timeslider to at

http://pads.kicad-pcb.org , I will remove it temporarily...

Thanks a lot for your work,

@disy-mk
Copy link

disy-mk commented Sep 15, 2013

I talked several times to the author of that plugin, but he did not seem to be too much interested in fixing that issue, or at least was always busy.

As Etherpad was less interesting for us the last months - due to the lack of some features - it lost our focus. Out of a personal interest I will soon spend some time on it again; also on this particual plugin :)

But this is not a promise ;)

@gedion
Copy link
Owner

gedion commented Sep 15, 2013

I am most certainly interested. I've honestly have not had the time. My
living work consumes my time and energy. Manuel, I'd greatly appreciate it
if you could delve into it.

On Sun, Sep 15, 2013 at 4:55 PM, Manuel Knitza [email protected]:

I talked several times to the author of that plugin, but he did not seem
to be too much interested in fixing that issue, or at least was always
busy.

As Etherpad was less interesting for us the last months - due to the lack
of some features - it lost our focus. Out of a personal interest I will
soon spend some time on it again; also on this particual plugin :)

But this is not a promise ;)


Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-24481205
.

@disy-mk
Copy link

disy-mk commented Sep 15, 2013

so be it. I'll TRY to do so asap.
Am 16.09.2013 um 00:06 schrieb Gedion Woldeselassie [email protected]:

I am most certainly interested. I've honestly have not had the time. My
living work consumes my time and energy. Manuel, I'd greatly appreciate it
if you could delve into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants