Update basic.py #1875
Open
Update basic.py #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the comment on the line where the font size is set to 18 says 28 instead of 18.
NitkarshChourasia
suggested changes
Jul 26, 2023
| @@ -1,34 +1,20 @@ | |||
| from fpdf import FPDF | |||
|
|
|||
| # Author: @NavonilDas | |||
There was a problem hiding this comment.
Only this is what to be removed.
Even as optional.
But, as we are approaching a standardized open sourced, so removing this may be legitimate.
But, removing the comments which make the program better is not good.
Comments and documentations are the essence as they help in understanding the program much more better.
Comments and documentations are the essence as they help in understanding the program much more better.Don't remove them.Restore them, please.This is not the standard and best practices of programming and that too, python programming language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the comment on the line where the font size is set to 18 says 28 instead of 18.