Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperation of concerns #1

Open
tacticiankerala opened this issue Feb 4, 2016 · 2 comments
Open

Seperation of concerns #1

tacticiankerala opened this issue Feb 4, 2016 · 2 comments

Comments

@tacticiankerala
Copy link

I played around with the LISP interpreter and I quite liked it :). Awesome job!

When I went through the code, I felt rather than having all the code in one class seperating the concerns would drastically improve readability and maintainability. For example, we can seperate the following responsibilities,

  1. Reading input from user
  2. Parsing
  3. Evaluating

And, if we keep the environment seperately then adding new functions need not have to touch any other part of the system.

@tacticiankerala
Copy link
Author

I forgot to mention that seperation of concern helps in extensibility also. For example, you can add new functionality like reading from a file very easily.

@adarsh-why
Copy link
Member

Thank you very much for spending your time to review the code.
I will separate the concerns and let you know.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants