Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of models does not update on landing page #889

Open
ValWood opened this issue May 16, 2024 · 3 comments
Open

Status of models does not update on landing page #889

ValWood opened this issue May 16, 2024 · 3 comments

Comments

@ValWood
Copy link

ValWood commented May 16, 2024

I am trying to flag my out-of-date models as "delete"

I have done this and saved,

But even after reloading, they still look like this on the landing page

Screenshot 2024-05-16 at 16 26 10

when I go back to the model they show as "delete"
Screenshot 2024-05-16 at 16 26 56

@ValWood
Copy link
Author

ValWood commented May 16, 2024

I also changed titles but they didn't update either...

@ValWood ValWood changed the title Status of models does not update on anding page Status of models does not update on landing page May 16, 2024
@vanaukenk
Copy link

@ValWood
I checked the three models listed above and it looks like they are all empty, i.e. no individuals.
I suspect that they're thus not being saved because we have a check in the system by which empty models are not saved.
I'd have to check with @kltm about what's the best thing to do here to delete them.

@kltm
Copy link
Member

kltm commented May 31, 2024

I'd verify w/@balhoff, but I believe the function BeforeSaveModelValidator in ./minerva-server/src/main/java/org/geneontology/minerva/server/validation/BeforeSaveModelValidator.java handles this logic.
My read of it is, to save, you need:

  • a title
  • a contributor
  • at least one individual ("node")

I don't think that "emptying" a model was ever a considered workflow. Odd that they managed to get saved in the first place; we could add something at some point to sweep those out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants