From ffed4f567494102a7932d91db39fd0ee986225bc Mon Sep 17 00:00:00 2001 From: Mark Sturdevant Date: Fri, 23 Oct 2026 14:25:58 -0700 Subject: [PATCH] ci: skip legacy test job when the discovered matrix is empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI - Legacy Subpackages has been failing on main and on PRs that touch legacy-ci.yml or quality-generic.yml since the flat-package restructure: the discovery step scans mellea_contribs/**, which no longer exists, so the matrix is always empty — and a reusable-workflow (uses:) job with an empty matrix fails the run instead of skipping. Add the same empty-matrix guard the test job in ci.yml already has so the job skips cleanly. Whether the legacy workflows should instead be deleted outright is tracked separately. Fixes #108 Assisted-by: Claude Code Signed-off-by: Mark Sturdevant --- .github/workflows/legacy-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/legacy-ci.yml b/.github/workflows/legacy-ci.yml index 731190fb..ceb34c58 100644 --- a/.github/workflows/legacy-ci.yml +++ b/.github/workflows/legacy-ci.yml @@ -74,6 +74,11 @@ jobs: test: needs: discover-subpackages + # Skip cleanly when the matrix is empty (no mellea_contribs/ subpackages + # changed — or the directory no longer exists post-restructure). Without + # this guard, a `uses:` job with an empty matrix fails the run instead + # of skipping (same guard as the test job in ci.yml). + if: fromJson(needs.discover-subpackages.outputs.matrix).include[0] != null strategy: matrix: ${{ fromJson(needs.discover-subpackages.outputs.matrix) }} max-parallel: 6