Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PX Proxy 0.10.0 does not ignore HTTP_PROXY #243

Open
MarcusP-P opened this issue Feb 24, 2025 · 2 comments
Open

PX Proxy 0.10.0 does not ignore HTTP_PROXY #243

MarcusP-P opened this issue Feb 24, 2025 · 2 comments
Labels

Comments

@MarcusP-P
Copy link

MarcusP-P commented Feb 24, 2025

If I set a global HTTP_PROXY environment variable on Windows to point to my px proxy, e.g. from a command prompt setx HTTP_PROXY http://127.0.0.1:3128/, px 0.10.0 will use that to connect to the next proxy, causing it to recursively talk to itself.

Process-1: Thread_8: 1740362946: /_socket_action/debug_callback/dprint: 2391578508352: Curl info: Uses proxy env variable no_proxy == '127.0.0.1,localhost'
Process-1: Thread_8: 1740362946: /_socket_action/debug_callback/dprint: 2391578508352: Curl info: Uses proxy env variable http_proxy == 'http://127.0.0.1:3128'
Process-1: Thread_8: 1740362946: /_socket_action/debug_callback/dprint: 2391578508352: Curl info: Hostname 127.0.0.1 was found in DNS cache
Process-1: Thread_8: 1740362946: /_socket_action/debug_callback/dprint: 2391578508352: Curl info: Trying 127.0.0.1:3128...
MainProcess: MainThread: 1740362946: /_handle_request_noblock/verify_request/dprint: Client address: 127.0.0.1

px 0.9.2 doesn't use those environment variables, so it handles it appropriately.

@genotrance
Copy link
Owner

This has been fixed in pymcurl devel - it's a simple fix if you can change those two lines into your installation.

genotrance/mcurl@18f798f#diff-124b35ef20f3c13b5ed2d8db7518d6c36f15ba97fd83ab8536ce042096461d63

@hjrb
Copy link

hjrb commented Feb 25, 2025

Please provide a fixed update release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants