Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors identified by R vendoring update #125

Open
paleolimbot opened this issue Mar 1, 2025 · 0 comments
Open

Fix errors identified by R vendoring update #125

paleolimbot opened this issue Mar 1, 2025 · 0 comments

Comments

@paleolimbot
Copy link
Contributor

A compiler warning:

geoarrow.c:1105:11: warning: unused variable 'chars_written' [-Wunused-variable]
 1105 |   int64_t chars_written = GeoArrowMetadataSerializeInternal(metadata_view, metadata);
      |           ^~~~~~~~~~~~~
geoarrow.c:1135:13: warning: unused variable 'chars_written' [-Wunused-variable]
 1135 |     int64_t chars_written = GeoArrowMetadataSerializeInternal(metadata_view, out);
      |             ^~~~~~~~~~~~~

...and ensure that running GEOARROW_BUNDLE=ON works with cmake --install (currently, the updates enabling a proper CMake install for a non-bundled version make this error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant