Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming considerations for BoundingRect #989

Open
kylebarron opened this issue Jan 31, 2025 · 0 comments
Open

Naming considerations for BoundingRect #989

kylebarron opened this issue Jan 31, 2025 · 0 comments

Comments

@kylebarron
Copy link
Member

Thanks for the tip on the native impl, I'll move to using that instead.

As far as naming goes (one of the truly hard problems in code), after looking at both the trait and the struct, I'm wondering if renaming the struct to Bounds might end up being a bit more appropriate. It seems like keeping geo::BoundingRect in line with the geo crate is important for discoverability/parity between this crate and geo. Additionally, the native BoundingRect struct includes an optional Z dimension (and I suspect potentially M at some point in the future) which, if we're being pedantic, makes it optionally not a "Rectangle." Other options might be something like Bbox or Extent, but those already feel like overloaded terms in the various "geo" code bases that exist.

Originally posted by @BlakeOrth in #979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant