You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Personally, I would go for a new AutocompleteQuery class (see src/Common/Query) so we make it consistent and structured for every provider.
That being said, we would probably need to check how many provider offer autocompletion to see if it worth it.
Otherwise, I would go for solution 2 here above that seems more flexible.
Note: Google Place Autocomplete returns limited information about places. It comes with Google Place details (the sessiontoken parameter allows, among other things, to link the two queries).
So I was planning to add Google Place Details [it also allows to return a place from its ID] in the same way as Google Place Autocomplete. But I'll wait for now.
All this to say, that the different providers that offer autocomplete do not necessarily return enough data. For example, Google Place Autocomplete returns very few data corresponding to the Address class.
The last 2 PR are aiming to add autocomplete support.
I like the idea but I think we need to figure out a consistent way to implement that across all providers that offer autocompletion.
#1118 by @nassuf
#1119 by @gdw96
Personally, I would go for a new
AutocompleteQuery
class (seesrc/Common/Query
) so we make it consistent and structured for every provider.That being said, we would probably need to check how many provider offer autocompletion to see if it worth it.
Otherwise, I would go for solution 2 here above that seems more flexible.
Any insight on this topic @Nyholm @willdurand ?
The text was updated successfully, but these errors were encountered: