Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using createUsingApiKey for Here in chain-provider #185

Closed
chriserikhaugli opened this issue Jun 27, 2021 · 1 comment
Closed

Using createUsingApiKey for Here in chain-provider #185

chriserikhaugli opened this issue Jun 27, 2021 · 1 comment

Comments

@chriserikhaugli
Copy link

chriserikhaugli commented Jun 27, 2021

General Information

GeocoderLaravel Version: 4.4
Laravel Version: 8.0
PHP Version: 7.4
Operating System and Version: Ubuntu 20.04

Issue Description

Here is now using apiKey instead of app_id and app_code in new applications.
geocoder-php (issue #1087) have fixed this by adding the Here::createUsingApiKey-method, and have left the constructor using id/code.

I can't find a way to use this new static method in the chain-provider in GeocoderLaravel, since as far I can see it is relying on the constructor in the provider setup.

Is this right, or is it something I have not figured out here?

Steps to Replicate

Adding Here in the geocoder.php:

'providers' => [
  Chain::class => [
    Here::class     => [
      env('I_ONLY_HAVE_A_HERE_KEY_NOT_AN_APP_ID_AND_APP_CODE'),
    ]
  ],
],
@chriserikhaugli chriserikhaugli changed the title Using createUsingApiKey for the Here in chain-provider Using createUsingApiKey for Here in chain-provider Jun 27, 2021
@chriserikhaugli
Copy link
Author

I now see that this is a duplicate of #181 .

Sorry, will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant