Add keep_alive() call when an error occurs in fetch_next(), to prevent permanent failure when redis restarts#492
Merged
geofmureithi merged 3 commits intoapalis-dev:mainfrom Jan 15, 2025
Conversation
Member
|
I think this should only happen when one encounters a specific error, could you provide some logs or more context of what you are encountering? |
Contributor
Author
|
You can reproduce by:
This error is coming from By recalling |
geofmureithi
requested changes
Jan 11, 2025
…t permanent failure when redis restarts
Contributor
Author
|
@geofmureithi updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, without this change when redis restarts, it seems apalis get's stuck repeating this error over and over:
After this change, on error
keep_alive()will re-register, so it's fixed on the next call.