Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splitquery deprecation warning #1085

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

geographika
Copy link
Contributor

@geographika geographika commented Feb 15, 2025

Overview

Fixes the following deprecation warning by using urlparse(q).query to get the querystring

/home/runner/work/pycsw/pycsw/pycsw/server.py:242: DeprecationWarning: urllib.parse.splitquery() is deprecated as of 3.8, use urllib.parse.urlparse() instead

This change caused a number of failing requests due to URLs being created with two ? - one from the Python code and one from the requests.txt file. These URLs were in the form http://127.0.0.1/?PYCSW_SERVER?config=tests/suites/csw30/default.yml.

Contributions and Licensing

  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@kalxas kalxas requested a review from tomkralidis February 24, 2025 23:32
@tomkralidis tomkralidis added this to the 3.0.0 milestone Feb 25, 2025
@tomkralidis tomkralidis merged commit ef2c511 into geopython:master Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants