Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse of nested multiple binary ops (#782) #932

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

barelsh
Copy link

@barelsh barelsh commented Dec 27, 2023

Overview

Bug fix - binary operations parsed incorrectly when used multiple times in a nested constraint

Related Issue / Discussion

Issue #782

Additional Information

The inner queries list was not clened between iterations, so the expressions were appended on the previous iterations' expressions, resulting in a wrong SQL query built. (first properties were duplicated into the second condition)

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

@kalxas
Copy link
Member

kalxas commented Jan 5, 2024

Thank you @barelsh for your contribution.
We will review in the following days

@tomkralidis tomkralidis merged commit 7e568cf into geopython:master Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants