Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configuration to YAML #937

Merged
merged 34 commits into from
Jan 6, 2024
Merged

update configuration to YAML #937

merged 34 commits into from
Jan 6, 2024

Conversation

tomkralidis
Copy link
Member

@tomkralidis tomkralidis commented Jan 5, 2024

Overview

Updates pycsw configuration from ini to YAML.

Related Issue / Discussion

Fixes #797

Additional Information

TODO

  • migration tool/script

External updates required

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@kalxas
Copy link
Member

kalxas commented Jan 5, 2024

We will also need to update the kubernetes helm charts when this is merged

@tomkralidis
Copy link
Member Author

k8s and helm charts first pass updated as part of this PR.

@tomkralidis
Copy link
Member Author

@tomkralidis tomkralidis changed the title [WIP] update configuration to YAML update configuration to YAML Jan 6, 2024
@tomkralidis tomkralidis added this to the 3.0.0 milestone Jan 6, 2024
Copy link
Member

@kalxas kalxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@kalxas kalxas self-requested a review January 6, 2024 13:28
@kalxas kalxas merged commit 1702f77 into master Jan 6, 2024
4 checks passed
@kalxas kalxas deleted the yaml-config branch January 6, 2024 15:27
@tomkralidis tomkralidis mentioned this pull request Jan 6, 2024
2 tasks
@pvgenuchten
Copy link
Contributor

Nice work, just to confirm: the override mechanism with environmental variables is still supported?

@tomkralidis
Copy link
Member Author

@pvgenuchten yes, environment variables are interpreted as per before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update configuration to YAML
4 participants