From a5102ad3e7770a0a21c82a47f0dbf9322bb51ab8 Mon Sep 17 00:00:00 2001
From: eastjames <47705516+eastjames@users.noreply.github.com>
Date: Sat, 24 Jun 2023 15:42:26 -0400
Subject: [PATCH] Provide location parameter to KS test, address issue #39
 (#55)

* reset for PR

* fixes to EVA.test_ks method

* fixes in EVA.test_ks for passing _fixed_parameters
---
 src/pyextremes/eva.py         | 7 +++++--
 tests/integration/test_eva.py | 5 +----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/pyextremes/eva.py b/src/pyextremes/eva.py
index d801076..59a696b 100644
--- a/src/pyextremes/eva.py
+++ b/src/pyextremes/eva.py
@@ -217,9 +217,12 @@ def AIC(self) -> float:
 
     def test_ks(self, significance_level: float = 0.05) -> KolmogorovSmirnov:
         return KolmogorovSmirnov(
-            extremes=self.extremes,
+            extremes=self.extremes_transformer.transformed_extremes,
             distribution=self.distribution.distribution,
-            fit_parameters=self.model.fit_parameters,
+            fit_parameters={
+                **self.model.fit_parameters,
+                **self.model.distribution._fixed_parameters,
+            },
             significance_level=significance_level,
         )
 
diff --git a/tests/integration/test_eva.py b/tests/integration/test_eva.py
index 0730de2..44aaa31 100644
--- a/tests/integration/test_eva.py
+++ b/tests/integration/test_eva.py
@@ -592,7 +592,4 @@ def test_test_ks(self, eva_model_bm_mle, eva_model_pot_mle, extremes_method):
             "POT": eva_model_pot_mle,
         }[extremes_method]
         assert isinstance(eva_model.test_ks(), KolmogorovSmirnov)
-        if extremes_method == "BM":
-            assert eva_model.test_ks().success
-        else:
-            assert not eva_model.test_ks().success
+        assert eva_model.test_ks().success