Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leaks #107

Open
stalestar opened this issue May 27, 2021 · 0 comments
Open

memory leaks #107

stalestar opened this issue May 27, 2021 · 0 comments

Comments

@stalestar
Copy link

stalestar commented May 27, 2021

Hi, thanks for grate work!

I find some memory leaks of the vsMotionDetection function:

  1. in the vs_vector_filter, vs_vector_append should be replaced by vs_vector_append_dup, and add vs_vector_del(&motions2); behind motionsfine = vs_vector_filter(&motions2, lm_match_better, &meanMatch); in vsMotionDetection meanwhile;
  2. add vs_array_free(matchQualities1); behind double meanMatch = cleanmean(matchQualities1.dat, matchQualities1.len, NULL, NULL); in vsMotionDetection;
  3. add vs_vector_fini(&motionscoarse); vs_vector_fini(&motionsfine); behind *motions = vs_vector_concat(&motionscoarse, &motionsfine); in vsMotionDetection.

You can check the code and fix the problems.
Best wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant