Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesium map dark when opened in the evening #10799

Closed
1 task done
mahmoudadel54 opened this issue Feb 5, 2025 · 0 comments · Fixed by #10803
Closed
1 task done

Cesium map dark when opened in the evening #10799

mahmoudadel54 opened this issue Feb 5, 2025 · 0 comments · Fixed by #10803
Assignees
@mahmoudadel54
Labels
enhancement
Milestone
2025.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Feb 5, 2025 •
edited by allyoucanmap
Loading

Description

We should implement new settings to configure the light source of 3D maps (Cesium.js), here the options we should implement:

  • Flashlight (default) see flashlight inside the sandcastle example
  • Date time set a specific date time, see how works the setTime function in the sandcastle example. When this option is selected an additional date time picker should be visible in UI
  • Sunlight the default cesium behavior

These new options should be placed inside the map settings panel

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

Cesium sandcastle with lighting examples
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.00 milestone Feb 5, 2025
@mahmoudadel54 mahmoudadel54 self-assigned this Feb 5, 2025
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 10, 2025
@mahmoudadel54
geosolutions-it#10799: Cesium map dark when opened in the evening
83c6826 
Description:
- handle showing select DD in mapSettings for cesium with 3 options: flashlight, sunlight, custom dateTime
- handle logic of setting lighting options for cesium if user select one of the 3 available options
- add unit test
- add translations
@mahmoudadel54 mahmoudadel54 mentioned this issue Feb 10, 2025
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Feb 10, 2025 that will close this issue
#10799: Cesium map dark when opened in the evening #10803
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 17, 2025
@mahmoudadel54
geosolutions-it#10799: Cesium map dark when opened in the evening [re…
c72b864 
…solve review comments]

Description:
- replace specific 3D lighting option with just 'lighting' in prop name in mapOptions, label, placeholder, translations
- refactor code and create sungle function 'updateFlashlightEffect' for handling applying the lighting map theme in Map.jsx
-  remove: DEFAULT_QUICK_TIME_SELECTORS  from MapSettings.jsx that used for dateTimePicker
- make sunlight is the default option for cesium map lighting
-  replace normal label with 'ControlLabel' for lighting mapSettings
- add the prop popupPosition="top" to dateTimePicker of lighting
- add space bet. DD and DateTimePicker of lighting on map settings modal
allyoucanmap pushed a commit that referenced this issue Feb 20, 2025
@mahmoudadel54
#10799: Cesium map dark when opened in the evening (#10803)
8818aa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmoudadel54 mahmoudadel54

Labels
enhancement
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10799: Cesium map dark when opened in the evening mahmoudadel54/MapStore2
1 participant
@mahmoudadel54