fix(geotiff.js): pass the options object to the GeoTIFF.from*() builders #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TheMrCam
requested changes
Nov 12, 2025
Collaborator
TheMrCam
left a comment
TheMrCam
left a comment
There was a problem hiding this comment.
I think we still want to pass options to makeRemoteSource in fromUrls, right? We're using the same options object for GeoTIFFOptions and for makeRemoteSource#options in fromUrl and fromCustomClient, so I'd assume we'd want the same in fromUrls.
| */ | ||
| export async function fromUrls(mainUrl, overviewUrls = [], options = {}, signal) { | ||
| const mainFile = await GeoTIFF.fromSource(makeRemoteSource(mainUrl, options), signal); | ||
| const mainFile = await GeoTIFF.fromSource(makeRemoteSource(mainUrl), options, signal); |
Collaborator
There was a problem hiding this comment.
Shouldn't makeRemoteSource still also get the options object, like above? Same for line 757
Suggested change
| const mainFile = await GeoTIFF.fromSource(makeRemoteSource(mainUrl), options, signal); | |
| const mainFile = await GeoTIFF.fromSource(makeRemoteSource(mainUrl, options), options, signal); |
| const mainFile = await GeoTIFF.fromSource(makeRemoteSource(mainUrl), options, signal); | ||
| const overviewFiles = await Promise.all( | ||
| overviewUrls.map((url) => GeoTIFF.fromSource(makeRemoteSource(url, options))), | ||
| overviewUrls.map((url) => GeoTIFF.fromSource(makeRemoteSource(url), options, signal)), |
Collaborator
There was a problem hiding this comment.
Suggested change
| overviewUrls.map((url) => GeoTIFF.fromSource(makeRemoteSource(url), options, signal)), | |
| overviewUrls.map((url) => GeoTIFF.fromSource(makeRemoteSource(url, options), options, signal)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took over @anton-seaice's PR #342.
This PR ensures that the
optionsobject is properly passed to the underlyingfrom*builder functions (fromUrl(),fromCustomClient(), etc).This fixes two issues: