From 2cc184cd582eac1188c19a659c91f0234837a219 Mon Sep 17 00:00:00 2001 From: Gerardo Perez Perez Date: Tue, 22 Sep 2015 17:43:14 -0500 Subject: [PATCH] fixed some problems with jshint --- README.md | 22 ++++++---------------- addon/components/crud-table.js | 6 ++++-- addon/utils/dateformat.js | 1 - package.json | 2 +- 4 files changed, 11 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index c9bc7ed..d32f8ba 100755 --- a/README.md +++ b/README.md @@ -26,12 +26,6 @@ Please let me know about anything you find is not working, or maybe some feature ember install ember-cli-crudtable ``` -or - -``` -ember install:addon ember-cli-crudtable -``` - After this you must install boostrap with bower ``` @@ -42,25 +36,21 @@ bower install bootstrap ##Current Status ![Current NPM](https://img.shields.io/github/tag/gerard2p/ember-cli-crudtable.svg) -(I'm not using any versioning convention, instead i'm just using the current date) - -And I'll be releasing a new version every month or every 5 features I add. +I'm now using a Mayor/Minor/Revision notation. -You can use the next command to get the latest build +So we can now use the npm notation correctly. ``` ember install ember-cli-crudtable@beta ``` -or - -``` -ember install:addon ember-cli-crudtable@beta -``` - --- ##Changelog + +### v1.0.0 +Since this versiĆ³n I'll put the changelog on the release section. + Maybe you want one of the older relases. ### v0.4.2 I made a lot of mistakes and v0.4.1 it's actually version v0.4.2 and accidentally I removed all the other versions from npm, but don't worry this version is still backwards compatible. diff --git a/addon/components/crud-table.js b/addon/components/crud-table.js index e67a545..621164f 100755 --- a/addon/components/crud-table.js +++ b/addon/components/crud-table.js @@ -118,7 +118,7 @@ var regenerateView = function(cmp) { Value: data, Choose: cmp.fields[field].OnChoose, Display: DF.format(data, cmp.fields[field].Format), - List: cmp.fields[field].List === true, + List: cmp.fields[field].List === false ? true:false, Suffix: cmp.fields[field].Suffix, Prefix: cmp.fields[field].Prefix, Label: cmp.fields[field].Label, @@ -187,7 +187,9 @@ var regenerateView = function(cmp) { }; var showmodal = function() { modalpromise = Ember.RSVP.defer('crud-table#showingmodal'); - $("#CrudTableDeleteRecordModal").modal('show'); + var modal = $("#CrudTableDeleteRecordModal"); + console.log($.fn.modal); + modal.modal('show'); }; var metadata = function(records, that) { var inflector = new Ember.Inflector(Ember.Inflector.defaultRules); diff --git a/addon/utils/dateformat.js b/addon/utils/dateformat.js index 053ba4a..53274dd 100644 --- a/addon/utils/dateformat.js +++ b/addon/utils/dateformat.js @@ -1,4 +1,3 @@ -import Ember from 'ember'; /* * Date Format 1.2.3 * (c) 2007-2009 Steven Levithan diff --git a/package.json b/package.json index 79c0265..29ce057 100755 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ember-cli-crudtable", - "version": "1.0.1", + "version": "1.0.2", "description": "This addon allows you to easly create a CRUD Table, it will take you only 5s!.", "directories": { "doc": "doc",