-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XSES: holidays are only recorded to the year 2023 #295
Comments
Hi @ValueRaider. XSES and some other calendars rely on hardcoded holidays. If such a calendar is created with an end date beyond the date to which holidays have been included then this error is necessarily raised. It's not a bug, just requires any user who wants the calendar to end later to offer a PR adding holidays, in this case for 2024. Users tend to offer up these PRs towards the end of the each year. For now, the following works: cal = xcals.get_calendar("XSES", start="2023-01-01", end="2023-12-31") |
I don't even see 2023 for "XSES" - how can it be fixed?
|
|
version is 4.2.5 - not sure if this is the problem. |
The 2023 dates for XSES were added via this PR which was merged prior to the 4.2.5 release. @MMCMA, could you run the following and post the print please... import exchange_calendars as xcals
print(xcals.__version__)
cal = xcals.get_calendar("XSES", start="2023-01-01", end="2023-12-31")
print(cal.last_session) |
It seems I had version 4.2.4 (installed via conda-forge) - though the |
No worries @MMCMA. We don't actively support conda (although someone might upload a version there). Glad you got it working. |
Fixed by #343 |
The text was updated successfully, but these errors were encountered: