Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimalize the printing, e.g. cli #4

Closed
chainsawriot opened this issue Mar 12, 2024 · 6 comments
Closed

Minimalize the printing, e.g. cli #4

chainsawriot opened this issue Mar 12, 2024 · 6 comments

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Mar 12, 2024 •
edited
Loading

Put cli in Suggests instead. Not at all important.
@chainsawriot
Copy link
Collaborator Author

Also crayon

@chainsawriot
Copy link
Collaborator Author

Should also think about the verbosity. tidyverse/readr#1532

@chainsawriot
Copy link
Collaborator Author

How readODS handles the verbosity.

https://github.com/ropensci/readODS/blob/803775d7db7866877ab31750ea15afc523646339/R/read_ods.R#L142-L151

@chainsawriot chainsawriot changed the title Make cli optional Minimalize the printing, e.g. cli Mar 14, 2024
@chainsawriot
Copy link
Collaborator Author

sergeant

https://github.com/hrbrmstr/sergeant/blob/9408208e41ecb2636d4a9856d32789ffb93b9d96/R/query.r#L213-L221

timetk

https://github.com/business-science/timetk/blob/ba787084ce0962b1e91949913c0dba80d3f05e3c/R/coersion-tk_tbl.R#L109

@chainsawriot
Copy link
Collaborator Author

GenomicDataCommons (bioc)

https://github.com/Bioconductor/GenomicDataCommons/blob/98830d1212844c71c3f32ac3a502c953d40c7c79/R/clinical.R#L76-L81

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Mar 15, 2024 •
edited
Loading

  • Make disclaimer that this package is not aimed for interactive use - So it should emit very few messages, and no color messages by default.
  • List out the differences
  • default all colorise to FALSE and put crayon to Suggests; and check for installation if colorise is TRUE.

chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
Reduce verbosity and remove colorization ref #4
0133207 
Also explicitly remove `problems` ref #7
chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
Reduce verbosity and remove colorization ref #4 (#16)
063621d 
Also explicitly remove `problems` ref #7
chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
Fix #17 and fix #4
1cb4a4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot