Fix staged index-related CLI/deployment skew bug (#40331)

Old deployments don't have these fields. We don't expect old un-upgraded backends to work against new CLIs forever, but the current docker setup doesn't support these yet so this is too fast. Plan to revisit enabling these in a couple months.

resolves #200

GitOrigin-RevId: c9411576307724a1fb64f741da873266920654aa

Author: thomasballinger

npm-packages/convex/src/cli/lib/components.ts

@@ -511,7 +511,7 @@ function printDiff(
       msg = msg.slice(0, -1); // strip last new line
       logFinishedStep(msg);
     }
-    if (rootDiff.enabled_indexes.length > 0) {
+    if (rootDiff.enabled_indexes && rootDiff.enabled_indexes.length > 0) {
       let msg = opts.dryRun
         ? `These indexes would be enabled:\n`
         : `These indexes are now enabled:\n`;
@@ -521,7 +521,7 @@ function printDiff(
       msg = msg.slice(0, -1); // strip last new line
       logFinishedStep(msg);
     }
-    if (rootDiff.disabled_indexes.length > 0) {
+    if (rootDiff.disabled_indexes && rootDiff.disabled_indexes.length > 0) {
       let msg = opts.dryRun
         ? `These indexes would be staged:\n`
         : `These indexes are now staged:\n`;

npm-packages/convex/src/cli/lib/deploy2.ts

@@ -157,9 +157,9 @@ export async function waitForSchema(
           msg = `Backfilling indexes (${indexesComplete}/${indexesTotal} ready)...`;
           // Set a more specific message if the backfill is taking a long time
           if (Date.now() - start > 10_000) {
-            const rootDiff = startPush.schemaChange.indexDiffs[""];
+            const rootDiff = startPush.schemaChange.indexDiffs?.[""];
             const indexName = (
-              rootDiff.added_indexes[0] || rootDiff.enabled_indexes[0]
+              rootDiff?.added_indexes[0] || rootDiff?.enabled_indexes?.[0]
             )?.name;
             if (indexName) {
               const table = indexName.split(".")[0];

npm-packages/convex/src/cli/lib/deployApi/finishPush.ts

@@ -73,8 +73,8 @@ export type DeveloperIndexConfig = z.infer<typeof developerIndexConfig>;
 export const indexDiff = looseObject({
   added_indexes: z.array(developerIndexConfig),
   removed_indexes: z.array(developerIndexConfig),
-  enabled_indexes: z.array(developerIndexConfig),
-  disabled_indexes: z.array(developerIndexConfig),
+  enabled_indexes: z.array(developerIndexConfig).optional(),
+  disabled_indexes: z.array(developerIndexConfig).optional(),
 });
 export type IndexDiff = z.infer<typeof indexDiff>;
 

npm-packages/convex/src/cli/lib/deployApi/startPush.ts

@@ -29,7 +29,7 @@ export type StartPushRequest = z.infer<typeof startPushRequest>;
 export const schemaChange = looseObject({
   allocatedComponentIds: z.any(),
   schemaIds: z.any(),
-  indexDiffs: z.record(componentDefinitionPath, indexDiff),
+  indexDiffs: z.record(componentDefinitionPath, indexDiff).optional(),
 });
 export type SchemaChange = z.infer<typeof schemaChange>;
 

npm-packages/convex/src/cli/lib/indexes.ts

@@ -45,9 +45,10 @@ type SchemaStateResponse = {
 type PrepareSchemaResponse = {
   added: IndexMetadata[];
   dropped: IndexMetadata[];
-  enabled: IndexMetadata[];
-  disabled: IndexMetadata[];
   schemaId: string;
+  // added August 22 2025
+  enabled?: IndexMetadata[];
+  disabled?: IndexMetadata[];
 };
 
 export async function pushSchema(
@@ -266,7 +267,7 @@ function logIndexChanges(
       `${dryRun ? "Would add" : "Added"} staged table indexes:\n${indexDiff}`,
     );
   }
-  if (indexes.enabled.length > 0) {
+  if (indexes.enabled && indexes.enabled.length > 0) {
     let indexDiff = "";
     for (const index of indexes.enabled) {
       indexDiff += `  [*] ${stringifyIndex(index)}\n`;
@@ -278,7 +279,7 @@ function logIndexChanges(
       : `These indexes are now enabled`;
     logFinishedStep(`${text}:\n${indexDiff}`);
   }
-  if (indexes.disabled.length > 0) {
+  if (indexes.disabled && indexes.disabled.length > 0) {
     let indexDiff = "";
     for (const index of indexes.disabled) {
       indexDiff += `  [*] ${stringifyIndex(index)}\n`;