Skip to content

Commit ab04358

Browse files
NicolappsConvex, Inc.
authored andcommitted
Fix disabled state of the “Change” button (#40449)
GitOrigin-RevId: 21fae4f89ee37b4cf0beddb18e72df65c8eabed7
1 parent d826c7e commit ab04358

File tree

1 file changed

+11
-10
lines changed
  • npm-packages/dashboard/src/components/deploymentSettings

1 file changed

+11
-10
lines changed

npm-packages/dashboard/src/components/deploymentSettings/Backups.tsx

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
useConfigurePeriodicBackup,
1616
} from "api/backups";
1717
import { useCurrentProject } from "api/projects";
18-
import { useId, useState } from "react";
18+
import { useId, useMemo, useState } from "react";
1919
import {
2020
DeploymentResponse,
2121
Team,
@@ -266,6 +266,13 @@ export function BackupScheduleSelector({
266266
const [minutesUtc, hoursUtc, , , dayOfWeekPart = "*"] = parts;
267267
const isWeekly = dayOfWeekPart !== "*";
268268
const dayOfWeekNum = isWeekly ? Number(dayOfWeekPart) : null;
269+
const defaultDayOfWeek = useMemo(
270+
() =>
271+
// We randomize the default day of week to spread out the backups
272+
// of users that don’t specify a custom time
273+
Math.floor(Math.random() * 7),
274+
[],
275+
);
269276
const date = new Date();
270277
date.setUTCHours(+hoursUtc, +minutesUtc);
271278

@@ -312,7 +319,7 @@ export function BackupScheduleSelector({
312319
<BackupScheduleSelectorInner
313320
defaultValue={date}
314321
defaultPeriodicity={isWeekly ? "weekly" : "daily"}
315-
defaultDayOfWeek={dayOfWeekNum}
322+
defaultDayOfWeek={dayOfWeekNum ?? defaultDayOfWeek}
316323
onClose={close}
317324
deployment={deployment}
318325
/>
@@ -330,7 +337,7 @@ export function BackupScheduleSelectorInner({
330337
}: {
331338
defaultValue: Date;
332339
defaultPeriodicity: "daily" | "weekly";
333-
defaultDayOfWeek: number | null;
340+
defaultDayOfWeek: number;
334341
onClose: () => void;
335342
deployment: DeploymentResponse;
336343
}) {
@@ -344,13 +351,7 @@ export function BackupScheduleSelectorInner({
344351
const [isSubmitting, setIsSubmitting] = useState(false);
345352

346353
const [periodicity, setPeriodicity] = useState(defaultPeriodicity);
347-
const [selectedDow, setSelectedDow] = useState(
348-
() =>
349-
defaultDayOfWeek ??
350-
// We randomize the default day of week to spread out the backups
351-
// of users that don’t specify a custom time
352-
Math.floor(Math.random() * 7),
353-
);
354+
const [selectedDow, setSelectedDow] = useState(defaultDayOfWeek);
354355

355356
return (
356357
<form

0 commit comments

Comments
 (0)