-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display memo in payment flow #156
Comments
Display Memo in Payment FlowIssueThe payment flow wasn't displaying the memo/description from Lightning invoices, which contains important context about the payment. SolutionAdded memo display functionality to the
private renderMemo(decodedInvoice: Invoice) {
if (!decodedInvoice.description) {
return null;
}
return html`
<p class="text-center mb-6 ${classes['text-neutral-secondary']}">
${decodedInvoice.description}
</p>
`;
}
return html`
<div class="flex flex-col justify-center items-center font-sans w-full">
${this.renderHeading(decodedInvoice)}
${this.renderMemo(decodedInvoice)}
${paymentStateElement}
</div>
`; Benefits
The memo is displayed with secondary text styling to maintain visual hierarchy while providing additional context for the payment. Should I make a PR for this? |
@arnavkirti that would be great, thank you! |
I have made a PR with changes. |
In
bc-send-payment
we should show the memo from the invoice if there is one.The text was updated successfully, but these errors were encountered: