You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a really cool project, I was looking through the code and noticed that you're using the inline prop in combination with isCodeBlock to determine if code is inline. I ran into this issue when implementing syntax highlighting in my own chat project, inlinewas removed in 9.0.0, using isCodeBlock alone should be enough to cover most cases, but what I did in my project was write a rehype plugin to add the inline prop if the parent div isn't a pre element:
I think isCodeBlock is fine on it's own, but adding this rehype plugin could help cover edge cases. I'd be happy to make a PR if you want to go this direction, at the very least we can remove inline.
Reproduce: Add console.log(inline) and see that it's value is undefined when inline code is rendered.
The text was updated successfully, but these errors were encountered:
This is a really cool project, I was looking through the code and noticed that you're using the
inline
prop in combination withisCodeBlock
to determine if code is inline. I ran into this issue when implementing syntax highlighting in my own chat project,inline
was removed in 9.0.0, usingisCodeBlock
alone should be enough to cover most cases, but what I did in my project was write a rehype plugin to add the inline prop if the parent div isn't apre
element:I think
isCodeBlock
is fine on it's own, but adding this rehype plugin could help cover edge cases. I'd be happy to make a PR if you want to go this direction, at the very least we can removeinline
.Reproduce: Add
console.log(inline)
and see that it's value is undefined when inline code is rendered.The text was updated successfully, but these errors were encountered: