This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Use "custom tabs" functionality to use the default browser for OAuth flow #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jornane
changed the title
|
If this would make #56 very easy, let's do that at the same time. |
|
We have a technical limitation, because when open an external browser the url cannot be gotten and you cannot either add a listener for the redirections/navigations. So the only approach can be using the oauth2 plugin. Do you want us to spend time tomorrow seeing that approach or after seeing the custom tab with the Browser capacitor has it has less priority? |
…pp should open when the browser is closed
jornane
force-pushed
the
feature/plugin-oauth2
branch
from
01a3c76
to
0f37e95
Compare
This was referenced Oct 23, 2020
Open
This was
linked to
issues
Oct 24, 2020
This was
linked to
issues
Oct 24, 2020
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android has a featured named "custom tabs", which allows supporting browsers to open a page within the app. This would give a better user experience in the OAuth flow, in part because we can re-use the users' session (doesn't need to login).
This might be a solution to #54 as well.