Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typhoon] Header Bar Custom Logo Incorrect logo served under some conditions #401

Open
markwtt opened this issue Dec 7, 2023 · 1 comment
Assignees
Labels
typhoon Typhoon theme

Comments

@markwtt
Copy link

markwtt commented Dec 7, 2023

Using theme cloned from Typhoon theme v1.0.11 The master Typhoon theme itself now shows v2.4.3
Grav itself and all plugins are up to date.

Issue is that the logo chosen in theme Header Bar Defaults is served correctly when site is accessed using https://www.domainname but if accessed with https://domainname the file "Artboard 1.png" is served, all other images on the site seem to work fine with either url.

It is a while since I did much with grav and wanting to get back up to speed, but don't know where to start with this one...

Here is a screen capture showing the different results from the two urls.

assets-path-issue

Any assistance on where to start would be much appreciated.

thanks
Mark

@markwtt markwtt added the typhoon Typhoon theme label Dec 7, 2023
@rhukster
Copy link
Member

rhukster commented Feb 2, 2024

Sorry @markwtt totally missed this issue of yours. What you are describing is the kind of thing that can happen i you have an env/domainname folder to environmental specific configuration:

https://learn.getgrav.org/17/advanced/environment-config

When you are in the admin for and the URL has the domainname in it and it matches a folder in env/, any changes or modifications will save into that env/domainname/config/... folder. however, when you visit www.domainname, and there is no specific env/ folder for it, then it falls back to the next config file which would be in the user/config/... folder. I suspect the difference in configuration is caused by this.

2 options:

  1. In the webserver (.htaccess etc) configuration any www.domainname.com URLs to simply redirect to domainname.com
  2. Remove the env/domainname folder and if you still need some form of configuration differences for different hosts (localhost etc) then just create a env/localhost folder and put any specific overrides there. That way the default for all other hosts (including domainname.com and www.domainname.com) will simply use the user/config/... folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typhoon Typhoon theme
Projects
None yet
Development

No branches or pull requests

2 participants