Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typhoon] Last.fm in Social links #406

Open
EvgenyADE opened this issue Jan 4, 2024 · 5 comments
Open

[typhoon] Last.fm in Social links #406

EvgenyADE opened this issue Jan 4, 2024 · 5 comments
Assignees
Labels
typhoon Typhoon theme

Comments

@EvgenyADE
Copy link

Hi
Is it possible to add Last.fm to the social links?

@EvgenyADE EvgenyADE added the typhoon Typhoon theme label Jan 4, 2024
@rhukster
Copy link
Member

rhukster commented Feb 2, 2024

So i've decided rather than just adding every single social network into the CSS and dropdown, a better solution is to provide custom fields. This will be in the next Typhoon release and to get lastfm to look decent you would have:

    -
      network: custom                                               # Social icon for network (choose custom to add your own)
      custom:
         network: Last FM                                           # Custom network name
         icon: 'tabler/brand-lastfm.svg'                            # Custom icon (svg_icons style format)
         colors: 'bg-red-500 text-white'                            # Custom icon colors in the format of 'bg-xxx text-xxx' (optional);
      link: https://lastfm.com/getgrav                              # External URL for network
      newtab: true                                                  # Open in new tab

FYI, updated with slightly tweaked format.

@aleclerc7
Copy link

Nice improvement! Thank you!

@thespad
Copy link

thespad commented Mar 14, 2024

Whatever I try I can't get the custom network to display (obviously, have updated to 2.4.5). It adds the anchor to the page footer, but not the icon. I've tried to keep it as simple as possible:

    -
      network: custom
      custom:
         network: Mastodon
         icon: 'user/assets/lsio/brand-mastodon.svg'
      link: 'https://mastodon.linuxserver.io/@linuxserver'

Tried a few different locations for the icon but it doesn't seem to make a difference, the page just shows an empty anchor:

<a href="https://mastodon.linuxserver.io/@linuxserver" aria-label="custom" class="text-custom  hover:filter hover:brightness-110 transition duration-300">
              
            </a>

@aleclerc7
Copy link

aleclerc7 commented Mar 14, 2024

Hello @thespad,

I think, using "svg icons", you should put your image in [theme]/images/icons (create the icons folder if it does not exist), and then simply put your icon's name: icon: 'brand-mastodon.svg'.

I did not try yet this new feature (#374) but I think it might solve your problem.

Kind regards.

@thespad
Copy link

thespad commented Mar 14, 2024

Yeah I've tried that, as well as tabler/brand-mastodon.svg (I've checked, it's there in the plugin icons folder), but still just get an empty anchor element on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typhoon Typhoon theme
Projects
None yet
Development

No branches or pull requests

4 participants