Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hotfix markdown fences #1885

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Flamenco
Copy link

Address issues from closed PR

@mahagr
Copy link
Member

mahagr commented Feb 26, 2018

@Flamenco Could you add link to the issue that was fixed?

@Flamenco
Copy link
Author

fixes #1840

@mahagr
Copy link
Member

mahagr commented Mar 2, 2018

Thank you.

@rhukster
Copy link
Member

rhukster commented Mar 9, 2018

I think you forgot to commit the language file? Should update the languages/en.yaml file to get the base language strings in there.

@Flamenco
Copy link
Author

@rhukster
Copy link
Member

BTW @Flamenco does this still work with latest Parsedown updates? Seems the 1.7.0+ releases have broken some more advanced markdown things.

@Flamenco
Copy link
Author

It should. It just escapes things so they are not treated as markdown. And then puts them back after calling the pre-processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants