Skip to content

Commit 34f56eb

Browse files
committed
http-175 Address review comments
Signed-off-by: davidradl <[email protected]>
1 parent cad7ed7 commit 34f56eb

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- Added http 2 support.
66
- Amend to not log HTTP request response and header values by default.
7+
- Added http 2 support.
78

89
## [0.22.0] - 2025-10-03
910

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -428,10 +428,9 @@ that implements interface `HttpPostRequestCallbackFactory<HttpRequest>` to creat
428428
of class `CustomHttpSinkPostRequestCallbackFactory` in `resources/META-INF/services/org.apache.flink.table.factories.Factory` file
429429
and then reference identifier `rest-sink-logger` in the HttpSink DDL property field `gid.connector.http.sink.request-callback`.
430430

431-
A default implementation that logs those pairs as *INFO* level logs using Slf4j
432-
([Slf4jHttpPostRequestCallback](src/main/java/com/getindata/connectors/http/internal/table/sink/Slf4jHttpPostRequestCallback.java))
433-
is provided.
434-
431+
A default implementation that logs those pairs as *INFO* level logs using Slf4j ([Slf4jHttpPostRequestCallback](src/main/java/com/getindata/connectors/http/internal/table/sink/Slf4jHttpPostRequestCallback.java)) is provided.
432+
If you would like to log more http content (that maybe contain sensitive information), then you can provide a customized version
433+
of this callback; for inspiration on how to customize in this way, look back in the git history of this file.
435434

436435
- Http Lookup Source processes responses that it gets from the HTTP endpoint along their respective requests. One can customize the
437436
behaviour of the additional stage of processing done by Table Function API by implementing

src/main/java/com/getindata/connectors/http/internal/table/lookup/JavaNetHttpPollingClient.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ private HttpRowDataWrapper processHttpResponse(
210210
boolean isError) throws IOException {
211211

212212
this.httpPostRequestCallback.call(response, request, "endpoint", Collections.emptyMap());
213-
request.getHttpRequest().uri();
214213
var responseBody = response.body();
215214

216215
log.debug("Received status code [{}] for RestTableSource request", response.statusCode());

0 commit comments

Comments
 (0)