Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$site->findPageOrDraft() does not work for nested drafts #6339

Open
tobimori opened this issue Mar 8, 2024 · 0 comments · May be fixed by #6354
Open

$site->findPageOrDraft() does not work for nested drafts #6339

tobimori opened this issue Mar 8, 2024 · 0 comments · May be fixed by #6354
Assignees
@distantnative
Labels
type: bug 🐛 Is a bug; fixes a bug

Comments

@tobimori
Copy link
Contributor

tobimori commented Mar 8, 2024 •
edited
Loading

Description

  • page-1 -> listed

    • page-2 > draft
      • page-3 > draft
        -> will fail

  • page-1 -> draft

    • page-2 > listed
      • page-3 > listed
        -> will work

  • page-1 -> listed

    • page-2 > draft
      • page-3 > listed
        -> will fail

Using $site->findPageOrDraft("page-1/page-2/page-3")

Expected behavior
I expect the method to recursively find draft pages as well.

Your setup

Kirby Version 4.1.2
@tobimori tobimori mentioned this issue Mar 8, 2024
Closed
tobimori added a commit to tobimori/kirby-seo that referenced this issue Mar 16, 2024
@tobimori
add helper method for findPageOrDraft, bypasses getkirby/kirby#6339
fa23801 
Signed-off-by: Tobias Möritz <[email protected]>
@distantnative distantnative self-assigned this Mar 23, 2024
distantnative added a commit that referenced this issue Mar 23, 2024
@distantnative
Include drafts in finding pages key recursively
94ea2a4 
Fixes #6339
@distantnative distantnative added this to the 4.2.0 milestone Mar 23, 2024
@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Mar 23, 2024
@distantnative distantnative linked a pull request Mar 23, 2024 that will close this issue
Draft
5 tasks
@distantnative distantnative linked a pull request Mar 23, 2024 that will close this issue
Include drafts in finding pages key recursively #6354
Draft
5 tasks
@bastianallgeier bastianallgeier modified the milestones: 4.2.0, 4.2.x Mar 27, 2024
therephil added a commit to visionbites/kirby-usage-reference that referenced this issue Jul 8, 2024
@therephil
fixes a bug where draft items would not be found
8554eb7 
those unfound items would then throw an error in the panel
see getkirby/kirby#6339
distantnative added a commit that referenced this issue Jul 24, 2024
@distantnative
Include drafts in finding pages key recursively
8960b69 
Fixes #6339
@distantnative distantnative removed this from the 4.4.x milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include drafts in finding pages key recursively getkirby/kirby
3 participants
@bastianallgeier @distantnative @tobimori