From cead2ba28d8f8a58d266160f884f4b349b5c024e Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:43:14 +0200 Subject: [PATCH 1/7] Remove the upper bound for Node versions Node versions are released faster than we update this line in Lift. Might as well not block users. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 45d2b11d..67db69cb 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "typescript": "^4.3.4" }, "engines": { - "node": ">=14.15.0 <21" + "node": ">=14.15.0" }, "files": [ "/dist" From 9e258b6ee5f09449adad74e1140a3ab2cd57fa0d Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:44:57 +0200 Subject: [PATCH 2/7] Remove Node 14 from tests as it's not supported by the latest SF v3 --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b168e750..ac66e794 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,6 @@ jobs: strategy: matrix: node: - - 14 - 16 - 18 - 20 From c955792da0878e1fc148dd6f3e4616ebc8c1d3a1 Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:46:17 +0200 Subject: [PATCH 3/7] Simplify the build matrix by not testing intermediary Node versions --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac66e794..68cfbe89 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,6 @@ jobs: matrix: node: - 16 - - 18 - 20 serverless: - "2.36.0" From e79ea0daa86c99481ed269294786ac2758afc451 Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:49:08 +0200 Subject: [PATCH 4/7] Remove tests on lower bound, v2 is old anyway --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 68cfbe89..c4386a70 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,6 @@ jobs: - 16 - 20 serverless: - - "2.36.0" - "2" - "latest" steps: From 792c15c0856de5111453cfdd92c8ffa9bb895216 Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:50:41 +0200 Subject: [PATCH 5/7] Upgrade actions versions --- .github/workflows/ci.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c4386a70..e1117cb8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,11 +18,11 @@ jobs: - "2" - "latest" steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - - uses: actions/cache@v2 + - uses: actions/cache@v4 with: path: ~/.npm key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('**/package.json') }} @@ -39,11 +39,11 @@ jobs: name: Lint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 16 - - uses: actions/cache@v2 + node-version: 20 + - uses: actions/cache@v4 with: path: ~/.npm key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }} @@ -54,11 +54,11 @@ jobs: name: Type runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 16 - - uses: actions/cache@v2 + node-version: 20 + - uses: actions/cache@v4 with: path: ~/.npm key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }} From 72650a5329aedf1a278109a52180ec6fd3aa3e8a Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 14:58:07 +0200 Subject: [PATCH 6/7] Disable fail-fast --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e1117cb8..fb1d37c9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,7 @@ jobs: name: Unit tests runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node: - 16 From 194ec410db1eec597bf718ad74f052edecf77d09 Mon Sep 17 00:00:00 2001 From: Matthieu Napoli Date: Wed, 28 Aug 2024 15:09:59 +0200 Subject: [PATCH 7/7] Add support for serverless v4 --- .github/workflows/ci.yml | 3 ++- package.json | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fb1d37c9..7df0adff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,8 @@ jobs: - 20 serverless: - "2" - - "latest" + - "3" + - "4" steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 diff --git a/package.json b/package.json index 67db69cb..35a1b59e 100644 --- a/package.json +++ b/package.json @@ -83,6 +83,6 @@ }, "types": "dist/src/plugin.d.ts", "peerDependencies": { - "serverless": "^2.36.0 || ^3" + "serverless": "^2.36.0 || ^3 || ^4" } }