Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigator.locks from user preferences request #1044

Closed
matthew-white opened this issue Oct 29, 2024 · 0 comments · Fixed by #1064
Closed

Remove navigator.locks from user preferences request #1044

matthew-white opened this issue Oct 29, 2024 · 0 comments · Fixed by #1064
Assignees
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

As of #1024, Frontend sends requests to update user preferences from the propagate() method of the UserPreferences class. Currently, each request is wrapped in navigator.locks.request(), but after discussion, @brontolosone and I think that isn't strictly necessary. This issue is to update propagate(), removing navigator.locks.request(). I have an idea about how to do so, so I'll start by giving that a try, then sharing my idea with @brontolosone once it's ready.

@matthew-white matthew-white added the refactor Improves code without altering behavior label Oct 29, 2024
@matthew-white matthew-white self-assigned this Oct 29, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Oct 29, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Nov 22, 2024
matthew-white added a commit that referenced this issue Nov 22, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

1 participant