You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sadiqkhoja suggested that we turn on the max-len ESLint rule. (We would turn on both max-len and vue/max-len, which are currently both turned off.) The max would be maybe 100 or 110 characters. I'm in favor of that rule change as well.
In the past, we've sometimes needed long lines in the template in order to ensure that text is trimmed. For example:
Previously, putting {{ $t('help.microsoft.pageForExcel') }} on its own line would result in white space on either side of the text. That's an issue in particular for Japanese, where text typically doesn't include space characters. However, I've been noticing that that no longer seems to be the case: the white space is trimmed, at least when the {{ ... }} is the only content of the element. (Maybe there was a related change in Vue 3 or Vue CLI?) That means that there's little reason to have long lines like these, so we could turn on max-len without having to regularly disable the rule.
We already have a number of long lines, so turning on max-len would require changing those lines or disabling the rule for those lines.
The text was updated successfully, but these errors were encountered:
@sadiqkhoja suggested that we turn on the
max-len
ESLint rule. (We would turn on bothmax-len
andvue/max-len
, which are currently both turned off.) The max would be maybe 100 or 110 characters. I'm in favor of that rule change as well.In the past, we've sometimes needed long lines in the template in order to ensure that text is trimmed. For example:
central-frontend/src/components/odata/analyze.vue
Line 56 in da77ddf
Previously, putting
{{ $t('help.microsoft.pageForExcel') }}
on its own line would result in white space on either side of the text. That's an issue in particular for Japanese, where text typically doesn't include space characters. However, I've been noticing that that no longer seems to be the case: the white space is trimmed, at least when the{{ ... }}
is the only content of the element. (Maybe there was a related change in Vue 3 or Vue CLI?) That means that there's little reason to have long lines like these, so we could turn onmax-len
without having to regularly disable the rule.We already have a number of long lines, so turning on
max-len
would require changing those lines or disabling the rule for those lines.The text was updated successfully, but these errors were encountered: