Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover cards #670

Closed
matthew-white opened this issue May 23, 2024 · 10 comments · Fixed by getodk/central-frontend#1067
Closed

Add hover cards #670

matthew-white opened this issue May 23, 2024 · 10 comments · Fixed by getodk/central-frontend#1067
Assignees
Labels
design verified Verified by a designer enhancement New feature or behavior frontend Requires a change to the UI needs testing Needs manual testing

Comments

@matthew-white
Copy link
Member

matthew-white commented May 23, 2024

See the story in the release criteria.

@matthew-white matthew-white added enhancement New feature or behavior frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer labels May 23, 2024
@matthew-white matthew-white self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central May 23, 2024
@dbemke
Copy link

dbemke commented Dec 9, 2024

Is the geometry (property) in the correct format (numbers...numbers)?
Image

@srujner
Copy link

srujner commented Dec 9, 2024

Some form names are cut off in the Firefox browser
bug1

@matthew-white
Copy link
Member Author

Thank you, those both look like issues. 👍 I've also noticed that in some cases, there is too much padding below the list of properties in the hover card for an entity list. For example, if you hover over the "basic" entity list here: https://test.getodk.cloud/#/projects/414/entity-lists

@matthew-white
Copy link
Member Author

I didn't have a chance to make these changes today, but I'll do so soon.

@srujner
Copy link

srujner commented Dec 11, 2024

Hey, shouldn't the Infocard be visible also on that page after hovering the mouse over any of the links?
Screenshot(216)

@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Dec 11, 2024
@matthew-white
Copy link
Member Author

Yes, good catch! It should. I'll make that change tomorrow.

The issue has been closed because we finished code review. That means that you can now view it on staging in addition to the QA server. However, I still need to make the changes for the issues described above. Let me know if you see any other issues involving hover cards.

@matthew-white
Copy link
Member Author

shouldn't the Infocard be visible also on that page after hovering the mouse over any of the links?

This should now be fixed.

@matthew-white matthew-white added design verified Verified by a designer and removed needs design review Needs verification from designer labels Dec 13, 2024
@matthew-white
Copy link
Member Author

@sadiqkhoja mentioned to me yesterday that he was seeing an issue with hover cards:

Forms with lengthy names show the card outside of the screen

In other words, if there wasn't enough space for the hover card on either the right or the left of the link, it was being shown partly offscreen. Instead, we want to show the hover card above or below the link if there isn't space for it on the right or left.

getodk/central-frontend#1097 was merged to address this issue, and the issue should now be fixed. Let me know if you ever notice a hover card being shown offscreen.

@matthew-white
Copy link
Member Author

matthew-white commented Dec 13, 2024

We're also tracking another issue with hover cards. It definitely affects hover cards for forms and may affect other hover cards as well. The issue is: In a hover card for a form, if the text in the second column is shorter than the text in the first column (i.e., if the form version is short), then the hover card will widen to fit the full width of the form name. The problem is that hover cards are not supposed to become arbitrarily wide. The form name is supposed to truncate if it's too long. I'm planning to fix this issue tomorrow.

@matthew-white
Copy link
Member Author

hover cards are not supposed to become arbitrarily wide. The form name is supposed to truncate if it's too long.

This should now be fixed.

Is the geometry (property) in the correct format (numbers...numbers)?

Some form names are cut off in the Firefox browser

I think these are the last two things that need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design verified Verified by a designer enhancement New feature or behavior frontend Requires a change to the UI needs testing Needs manual testing
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

3 participants