-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover cards #670
Comments
Thank you, those both look like issues. 👍 I've also noticed that in some cases, there is too much padding below the list of properties in the hover card for an entity list. For example, if you hover over the "basic" entity list here: https://test.getodk.cloud/#/projects/414/entity-lists |
I didn't have a chance to make these changes today, but I'll do so soon. |
Yes, good catch! It should. I'll make that change tomorrow. The issue has been closed because we finished code review. That means that you can now view it on staging in addition to the QA server. However, I still need to make the changes for the issues described above. Let me know if you see any other issues involving hover cards. |
This should now be fixed. |
@sadiqkhoja mentioned to me yesterday that he was seeing an issue with hover cards:
In other words, if there wasn't enough space for the hover card on either the right or the left of the link, it was being shown partly offscreen. Instead, we want to show the hover card above or below the link if there isn't space for it on the right or left. getodk/central-frontend#1097 was merged to address this issue, and the issue should now be fixed. Let me know if you ever notice a hover card being shown offscreen. |
We're also tracking another issue with hover cards. It definitely affects hover cards for forms and may affect other hover cards as well. The issue is: In a hover card for a form, if the text in the second column is shorter than the text in the first column (i.e., if the form version is short), then the hover card will widen to fit the full width of the form name. The problem is that hover cards are not supposed to become arbitrarily wide. The form name is supposed to truncate if it's too long. I'm planning to fix this issue tomorrow. |
This should now be fixed.
I think these are the last two things that need to be fixed. |
See the story in the release criteria.
The text was updated successfully, but these errors were encountered: