Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for QR code where embedded text is long #799

Open
matthew-white opened this issue Nov 26, 2024 · 0 comments
Open

Account for QR code where embedded text is long #799

matthew-white opened this issue Nov 26, 2024 · 0 comments
Labels
frontend Requires a change to the UI i18n Internationalization

Comments

@matthew-white
Copy link
Member

As of #746, we show text below the draft testing QR code, where the text is embedded in the image. For #666, we plan to add text below the app user QR code (the project name and/or the app user name).

We don't currently wrap the text below the QR code, which means that it has the potential to become long. For #666, we'll probably need to figure out some way to wrap the text. Maybe we could use Intl.Segmenter to break up the text into words. Once we have text wrapping in place for #666, I think we should probably apply it to the draft testing QR code. "Temporary Testing Code" isn't the shortest string in English, so I assume it will be even longer in other locales.

I'm filing this issue in part because I think we should remember to check on the text below the draft testing QR code once translations have come in for that text. Because of how we float the image in the component, if the text below the QR code becomes too long, it will crowd out the explanatory text on the right.

@matthew-white matthew-white added frontend Requires a change to the UI i18n Internationalization labels Nov 26, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires a change to the UI i18n Internationalization
Projects
Status: 🕒 backlog
Development

No branches or pull requests

1 participant