Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading form containing duplicate properties (with different capitalization) - information in the warning #845

Open
dbemke opened this issue Dec 11, 2024 · 2 comments
Labels
entities Multiple Encounter workflows nicer error More understandable error messages

Comments

@dbemke
Copy link

dbemke commented Dec 11, 2024

Problem description

If a user tries to add a form or a new version of a form containing duplicate properties there’s the warning “The entity definition within the form is invalid. Multiple Form Fields cannot be saved to a single property.”
If a new version of a form tries to add the duplicate property the users sees more information (which property cannot be added).

Steps to reproduce the problem

  1. In “Forms” tab click “+New” and upload the form containing 2 properties (with different capitalization).
    movie entities (1).xlsx.txt

Screenshot

sameporpertisInFrom

Expected behavior

There could be more information about the duplicate property in all warnings.

Central version shown in version.txt

https://staging.getodk.cloud/
versions:
20878c7 (v2024.2.1-11-g20878c7)
+c9b8bef4652436d7d055d8777d9e84966ecba661 client (v2024.2.1-57-gc9b8bef4)
+313da04aaa3133978a3ef31dcc3cdc63bbbc152a server (v2024.2.0-118-g313da04a)
https://test.getodk.cloud/
versions:
801ab50 (v2024.2.1-10-g801ab50)
+5e95312bc6177ed79f170d8851da39fe327219d4 client (v2024.2.1-63-g5e95312b)
+4355d9e4c3a0f7bb6b694aad4cf318145905da2e server (v2024.2.0-114-g4355d9e4)

@matthew-white
Copy link
Member

I agree that it'd be helpful to list more information in this error message. 👍 It should also be translated (#489). It sounds like this is a preexisting issue, so I think we can wait to work on it until after v2024.3 is released.

@matthew-white matthew-white added entities Multiple Encounter workflows nicer error More understandable error messages labels Dec 11, 2024
@matthew-white
Copy link
Member

matthew-white commented Dec 11, 2024

Just to be clear, when we solve this issue, I think we would do so for all cases in which the error message is shown. Not just in the case where there are properties whose names are duplicates except for case (related: #769).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Multiple Encounter workflows nicer error More understandable error messages
Projects
None yet
Development

No branches or pull requests

2 participants